Re: [PATCH] arm: Fix build error with context tracking calls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Frederic Weisbecker <fweisbec@xxxxxxxxx> writes:

> 2013/9/14, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx>:
>> On Fri, Sep 13, 2013 at 07:03:34PM +0200, Frederic Weisbecker wrote:
>>> diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c
>>> index 247091b..859c8df 100644
>>> --- a/kernel/context_tracking.c
>>> +++ b/kernel/context_tracking.c
>>> @@ -51,6 +51,15 @@ void context_tracking_user_enter(void)
>>>  	unsigned long flags;
>>>
>>>  	/*
>>> +	 * Repeat the user_enter() check here because some archs may be calling
>>> +	 * this from asm and if no CPU needs context tracking, they shouldn't
>>> +	 * go further. We can remove that check here once these archs support
>>> the static key
>>> +	 * check.
>>
>> The only (minor) comment on this is that the above would fail checkpatch,
>> but that's not a good enough reason to respin it if you've already applied
>> it IMHO.
>>
>
> Ah I haven't yet pushed that patch anywhere so I can definetly fix
> that. Thanks for the review. BTW, I initially first thought this fix
> could go through your tree but if you prefer I can push it through
> Ingo to the context tracking bits.
>
> Just tell me either way.

Frederic, I suggest you queue it directly for v3.12-rc.  Thanks,

Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux