Re: [PATCH 1/2] ARM: OMAP: clean up some smatch warnings, fix some printk(KERN_ERR ...

[Tony Lindgren <tony@xxxxxxxxxxx>]

* Paul Walmsley <paul@xxxxxxxxx> [120807 03:35]:
> --- a/arch/arm/mach-omap1/lcd_dma.c
> +++ b/arch/arm/mach-omap1/lcd_dma.c
> @@ -94,7 +94,6 @@ void omap_set_lcd_dma_b1_rotation(int rotate)
>  	if (cpu_is_omap15xx()) {
>  		printk(KERN_ERR "DMA rotation is not supported in 1510 mode\n");
>  		BUG();
> -		return;
>  	}
>  	lcd_dma.rotate = rotate;
>  }
> @@ -154,7 +153,6 @@ static void set_b1_regs(void)
>  		break;
>  	default:
>  		BUG();
> -		return;
>  	}
>  
>  	vxres = lcd_dma.vxres ? lcd_dma.vxres : lcd_dma.xres;
> @@ -234,7 +232,6 @@ static void set_b1_regs(void)
>  		break;
>  	default:
>  		BUG();
> -		return;	/* Suppress warning about uninitialized vars */
>  	}
>  
>  	if (cpu_is_omap15xx()) {

I think these will cause new randconfig warnings without CONFIG_BUG set.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html