Re: [PATCH] OMAPDSS: Add timings for ChiMei G121S1-L01/L02 and G121X1-L01 LCD displays
Hi, On Tuesday 17 July 2012 09:57 PM, Jassi Brar wrote:
[CC'ing OMAPDSS matinainer] On 17 July 2012 19:31, Raphael Assenat <raph@xxxxxx> wrote:Add timings for ChiMei G121S1-L01/L02 and G121X1-L01 LCD displays.Display panels are board specific and there is no limit to the number of panels that could be connected to omap dss. Does it make sense to get panel params via DT? Or at least have them come from board file? (esp when there is hardly a panel shared by two boards, and some panels aren't even used by any board in mainline)
A panel specific param should stay in the panel driver, it's something which is specific to the panel and not the platform it is in, things like the gpio reset number, i2c connections with the panel etc would make sense to come via DT/board file.
It's true that currently omap platforms don't share the same panels, but there is no stopping us to do that. We could remove the default panel and attach a new one, even though we won't upstream non default panels in the DT/board file, it would be always easier to make this change in software if most of the panel specific info stays in the panel driver.
Also, 2 platforms of different SoC's may use the same panel. Currently the panel drivers are SoC specific, but there is work being done between different display maintainers so that the same panel driver works across different SoCs.
Archit -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html