Re: [RFC PATCH 11/11] ARM: DT: Add support to system control module for OMAP4

"Cousson, Benoit" <b-cousson@xxxxxx> · Wed, 30 May 2012 10:38:55 +0200

On 5/29/2012 11:49 AM, Konstantin Baydarov wrote:

   Hi, Eduardo.

On 05/25/2012 12:26 PM, Eduardo Valentin wrote:

This patch add device tree entries on OMAP4 based boards
for System Control Module (SCM).

Signed-off-by: Eduardo Valentin<eduardo.valentin@xxxxxx>
---
  arch/arm/boot/dts/omap4.dtsi |   13 +++++++++++++
  1 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
index 359c497..d2cb392 100644
--- a/arch/arm/boot/dts/omap4.dtsi
+++ b/arch/arm/boot/dts/omap4.dtsi
@@ -272,5 +272,18 @@
  			ti,hwmods = "mmc5";
  			ti,needs-special-reset;
  		};
+
+		ctrl_module_core: ctrl_module_core@4a002000 {
+			compatible = "ti,omap4-control";
+			ti,hwmods = "ctrl_module_core";
+			bandgap {
+				compatible = "ti,omap4460-bandgap";
+				interrupts =<0 126 4>; /* talert */
+				ti,tshut-gpio =<86>; /* tshut */
+			};

I believe that CPU-specific bandgap definition should be moved to bard specific dts.



Mmm, why, since it is CPU specific and not board specific. I has to be 

in the SoC file.


Regards,
Benoit
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

