RE: [PATCH] ARM: OMAP2+: CLEANUP: Remove ARCH_OMAPx ifdef from struct dpll_data

["Hiremath, Vaibhav" <hvaibhav@xxxxxx>]

On Tue, May 15, 2012 at 03:54:11, Hilman, Kevin wrote:
> Vaibhav Hiremath <hvaibhav@xxxxxx> writes:
> 
> > From: Kevin Hilman <khilman@xxxxxx>
> >
> > There are certain fields inside 'struct dpll_data' which are
> > included under ARCH_OMAP3 and ARCH_OMAP4 option, which makes it
> > difficult to use it for new devices like, am33xx, ti81xx, etc...
> >
> > So remove the ifdef completely, this will add few fields to the struct
> > unused, but it improves readability and maintainability of the code.
> >
> > Signed-off-by: Kevin Hilman <khilman@xxxxxx>
> > Signed-off-by: Vaibhav Hiremath <hvaibhav@xxxxxx>
> > Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> > Cc: Paul Walmsley <paul@xxxxxxxxx>
> > Cc: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
> > Cc: R Sricharan <r.sricharan@xxxxxx>
> > ---
> > Since Kevin had provided this idea and code change,
> > making this patch under his authorship.
> 
> Be sure to give yourself credit for writing the changelog.  Normally, if
> you make changes/additions to patch, you can add a line just before your
> signoff.  Something like:
> 
> [hvaibhav@xxxxxx: wrote detailed changelog]
> 

Ok...

Paul,
Can you please add above statement, when you merge it into your repo?


Thanks,
Vaibhav
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html