Re: [PATCH v2] OMAP2+: UART: Add mechanism to probe uart pins and configure rx wakeup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Fri, May 11, 2012 at 12:41 AM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> * Govindraj.R <govindraj.raja@xxxxxx> [120510 06:09]:
>> From: "Govindraj.R" <govindraj.raja@xxxxxx>
>>
>> The commit (bce492c0  ARM: OMAP2+: UART: Fix incorrect population of
>> default uart pads) removed default uart pads that where getting populated
>> and which was making rx pin wakeup capable. If uart pads was used in
>
> Nitpick.. this should say "were used" here                 ^^^

will change this.

>
>> --- a/arch/arm/mach-omap2/serial.c
>> +++ b/arch/arm/mach-omap2/serial.c
>> @@ -295,8 +353,7 @@ void __init omap_serial_board_init(struct omap_uart_port_info *info)
>>               bdata.pads = NULL;
>>               bdata.pads_cnt = 0;
>>
>> -             if (cpu_is_omap44xx() || cpu_is_omap34xx())
>> -                     omap_serial_fill_default_pads(&bdata);
>> +             omap_serial_check_wakeup(&bdata, uart);
>
> Should this section become:
>
>                if (!info) {
>                        omap_serial_check_wakeup(&bdata, uart);
>                        omap_serial_init_port(&bdata, NULL);
>                } else {
>                        omap_serial_init_port(&bdata, &info[uart->num]);
>                }
>
> As if you have bdata, then there should not be anything to mux,
> right?

populating bdata should not depend on port_info,
omap_serial_board_init takes only port info parameter and tries to populate
wakeup parameter since it has not received the same from board file.
And board file may or may not pass port info.

So populating bdata -> for uart wakeup pin should not be coupled with
availability of port info.

--
Thanks,
Govindraj.R
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux