|
|
Re: [PATCH 2/2] Add LCD support for the LogicPD OMAP3530 DevKits |
On Mon, 2012-05-07 at 15:21 -0400, Ashwin Bihari wrote:
> Use the generic DSS panel driver that provides support for
> the 4.3" Sharp LQ043T1DG01 that comes standard on the
> OMAP3530 SOM-LV and Torpedo DevKits.
>
> Signed-off-by: Ashwin Bihari <ashwin.bihari@xxxxxxxxxxx>
> ---
> arch/arm/mach-omap2/board-omap3logic.c | 147 ++++++++++++++++++++++++++++++++
> 1 files changed, 147 insertions(+), 0 deletions(-)
<snip>
> +static int omap3logic_panel_enable_lcd(struct omap_dss_device *dssdev)
> +{
> + gpio_set_value(LCD_PANEL_PWR, 1);
> + if (machine_is_omap3530_lv_som())
> + gpio_set_value(OMAP3530_LV_SOM_BACKLIGHT_PWR, 1);
> + else if (machine_is_omap3_torpedo()) {
> + gpio_set_value(OMAP3530_TORPEDO_BACKLIGHT_PWR, 1);
> +
> + gpio_set_value(OMAP3530_TORPEDO_MDISP, 1);
> + }
> +
> + return 0;
> +}
> +
> +static int omap3logic_panel_disable_lcd(struct omap_dss_device *dssdev)
> +{
> + gpio_set_value(LCD_PANEL_PWR, 0);
> + if (machine_is_omap3530_lv_som())
> + gpio_set_value(OMAP3530_LV_SOM_BACKLIGHT_PWR, 0);
> + else if (machine_is_omap3_torpedo()) {
> + gpio_set_value(OMAP3530_TORPEDO_BACKLIGHT_PWR, 0);
> +
> + gpio_set_value(OMAP3530_TORPEDO_MDISP, 0);
> + }
> +
> + return 0;
> +}
This doesn't play well with device-tree. We can't do such callbacks when
we move to DT.
I know we have similar code for other boards, and this can't be properly
fixed right now, but I'm still a bit hesitant to add more such code
because I'm the one that has to clean it up later for DT =).
I can handle the LCD_PANEL_PWR gpio, but the backlight is something that
should be removed from the panel enable callbacks. You could look at
drivers/video/backlight/ and see if there's something there that could
be used for your board. Or implement a new BL driver, if nothing fits.
Tomi
Attachment:
signature.asc
Description: This is a digitally signed message part
|