RE: [PATCH-V5 3/3] ARM: OMAP: Make OMAP clocksource source selection using kernel param

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Thu, 26 Apr 2012, Hiremath, Vaibhav wrote:

> On Thu, Apr 26, 2012 at 20:40:34, Paul Walmsley wrote:
> > On Wed, 25 Apr 2012, Vaibhav Hiremath wrote:
> > 
> <snip>
> > > +
> > > +	sync32k_ick = clk_get(NULL, "omap_32ksync_ick");
> > > +	if (!IS_ERR(sync32k_ick))
> > > +		clk_enable(sync32k_ick);
> > 
> > You've added hwmod data for this IP block, which is good.  This will 
> > presumably cause the IP block to be idled on boot.  But you haven't 
> > converted this code to use either the hwmod enable code -- just using 
> > clk_get() isn't enough.  (Better would be to use a driver and the PM 
> > runtime functions, of course, but maybe this runs too early?)
> > 
> > If the 32k sync timer is in OCP force-idle, then that might produce the 
> > hangs you're seeing.
> > 
> 
> I tried disabling all idle related flags in hwmod entry but no change in 
> observation, kernel still hangs.
> 
> I even conformed the register content by connecting debugger, and it is set 
> to No-idle state.

Okay, thanks for testing.  Please do update this patch to use 
omap_hwmod_enable(), etc.; see for example omap_dm_timer_init_one().


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux