Re: [PATCH 6/6] twl4030-usb: Don't report EVENT_ID when there is VBUS.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Wed, Apr 25, 2012 at 10:33 AM, NeilBrown <neilb@xxxxxxx> wrote:
> Some USB chargers tie the ID pin low via various resistors.
> So they can cause VBUS to be high and ID to be low.
>
> The 'A' end of an OTG cable never receives VBUS, it only ever generates it.
>
> So if we see VBUS and are not generating it, this must be a charger,
> not the A end of an OTG cable, so in that case, ignore the fact that
> ID is low.
>
> This assumes that VBUS_PRES isn't asserted when the charge pump is
> providing VBUS.  The document isn't clear on this and some experiments
> suggest that it isn't.

Like already mentioned, this is not what I see on pandora. I don't
know, maybe it's due to some errata or different versions of TWL chip
act different, or perhaps even board design issue, but that's how it
is here.

If you look at git history, this has been changed back and forth
several times, like in commit def6f8b9. Perhaps some platform_data
could be added to handle this, I don't know..

>
> Signed-off-by: NeilBrown <neilb@xxxxxxx>
> ---
>
>  drivers/usb/otg/twl4030-usb.c |   19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/usb/otg/twl4030-usb.c b/drivers/usb/otg/twl4030-usb.c
> index bd8fe9b..990400f 100644
> --- a/drivers/usb/otg/twl4030-usb.c
> +++ b/drivers/usb/otg/twl4030-usb.c
> @@ -268,15 +268,16 @@ static enum usb_phy_events twl4030_usb_linkstat(struct twl4030_usb *twl)
>                        STS_HW_CONDITIONS);
>        if (status < 0)
>                dev_err(twl->dev, "USB link status err %d\n", status);
> -       else if (status & (BIT(7) | BIT(2))) {
> -               if (status & (BIT(7)))
> -                        twl->vbus_supplied = true;
> -
> -               if (status & BIT(2))
> -                       linkstat = USB_EVENT_ID;
> -               else
> -                       linkstat = USB_EVENT_VBUS;
> -       } else
> +       else if (status & (BIT(7))) {
> +               /* We have VBUS so ignore ID_PRES - it is only meaningful
> +                * as an indicator of an A plug when there is no
> +                * VBUS.
> +                */
> +               twl->vbus_supplied = true;
> +               linkstat = USB_EVENT_VBUS;
> +       } else if (status & BIT(2))
> +               linkstat = USB_EVENT_ID;
> +       else
>                linkstat = USB_EVENT_NONE;
>
>        dev_dbg(twl->dev, "HW_CONDITIONS 0x%02x/%d; link %d\n",
>
>

-- 
Gražvydas
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Free Online Dating]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux