Re: Please help in adding ams-delta support to ASoC
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
Hi, Arun K S wrote:
On Fri, Jun 19, 2009 at 4:20 AM, Janusz Krzysztofik<jkrzyszt@xxxxxxxxxxxx> wrote:After all, could someone please give me an advise, what tree, even with buggy omap1510 mcbsp/dsp support, should I base my work on for best results?You have to use current omap tree with the patches from current sound tree(ASoC omap platform drivers changes) for testing the driver.
Arun,Thanks, from now on I use l-o master, right? As I do my development using OE, I am still investigating how to set up a bb recipe to get ALSA git tree applied over l-o.
Arun K S wrote:
On Fri, Jun 19, 2009 at 4:20 AM, Janusz Krzysztofik<jkrzyszt@xxxxxxxxxxxx> wrote:Arun K S wrote:On Thu, Jun 18, 2009 at 4:40 AM, Janusz Krzysztofik<jkrzyszt@xxxxxxxxxxxx> wrote:... I retried the new driver on commit 90e758af52ba803cba233fabee81176d99589f09 and confirmed the prevoiusly seen hangup. I found that it was omap_mcbsp_request() never returning back from.I faced the same issue while writing ASoC driver for tlv320aic23b codec. You can have a look at this thread: http://www.mail-archive.com/linux-omap@xxxxxxxxxxxxxxx/msg03852.htmlInitially i used to add the omap_mcbsp_request() at the boot time, other wise it hangs up. ... I believe there are some patches from Russel for the DSP memory mapping during 2.6.29 kernel.
Jarkko Nikula wrote:
On Thu, 18 Jun 2009 13:40:56 +0200 Janusz Krzysztofik <jkrzyszt@xxxxxxxxxxxx> wrote:Then I retired the same on the commit d8376cc482b241701f7606c81ad578b90853e175 and got similiar hangup.Can you move this boot time initialization moment around with xxx_initcall variants to see what is the point where block is not anymore accessable? Basically around the DSP power up and idle code (were there such code for older audio drivers?) and where unused clocks are disabled (functions clk_disable_unused and omap1_clk_disable_unused).
Arun, Jarkko,Thanks. Fortunatelly, I can confirm that the problem of omap_mcbsp_request() not returning back when called too late, has been already solved and no longer applies to 2.6.30, be it omap or mainline, with or without a working dsp.
Tony Lindgren wrote:
* Janusz Krzysztofik <jkrzyszt@xxxxxxxxxxxx> [090618 14:52]:Tony Lindgren wrote:AFAICS there is no DSP code in mainline at all, so the answer is no, DSP was likely not powered up at all.* Peter Ujfalusi <peter.ujfalusi@xxxxxxxxx> [090618 12:03]:On Wednesday 17 June 2009 17:12:38 ext Janusz Krzysztofik wrote:One thing that I have noticed is that the McBSP1 (and 3) is under the DSP Public Peripherals, while McBSP2 is under MPU Public Peripherals (in OMAP1510).Janusz Krzysztofik wrote:... got the answer fromomap_msbsp_dump_reg(): all mcbsp1 register read operations returned 0xffff. So it looks like I simply get no acccess to mcbsp1 at all.On omap1, DSP needs to be powered and idled before some mcbsp clocks can be used. Or at least needs to be powered up.We at least used to have code to power and idle the DSP even without the dspgateway compiled in.. Sorry I don't remember the details. But most likely you need to have the dspgateway patch enabled.
I hacked in the prevoiusly removed dsp_common.c containing omap_dsp_init(), with all header files required for successfull compilation, and finally got my driver working on top of current l-o.
Jarkko, Peter, Mark, Tony, Arun, Thanks for your help.It seams that dsp_common.c with its omap_dsp_init() used to be always compiled into the kernel, even if the rest of dspgateway code was not compiled or compiled as a module. This file, initially existing in arch/arm/plat-omap, was moved to drivers/dsp (commit 23ed8b5cf043a9cd40b5d415645b3543357d9a1a), and then removed completely (commit 2512fd29db4eb09e82d182596304c7aaf76d2c5c), together with other dspgateway code. Since then, McBSP ports that are DSP public peripherals have probably no chance to work, at least on omap1510, as I have verified.
Perhaps this single file (or its part with omap_dsp_init() at least) should never happen to be moved out of arch/arm/plat-omap? One of its related header files, dsp_common.h, has survived in the tree after it was moved to include/asm-arm/arch-omap/ (commit d23b6a447c9cd1d7376c5ec109b4be015a121eec), and then to arch/arm/plat-omap/include/map/.
Can I do anything to get omap_dsp_init() back into the omap tree? Could I just start with readding that old dsp_common.c, including any necessary header files, back to arch/arm/plat-omap/dsp? Or what other way should I take to restore omap1510 mcbsp1/3 support back?
Thanks, Janusz -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html