Re: [PATCH] nilfs2_ss_manager: fix TypeError at exit

[Jiro SEKIBA <jir@xxxxxxxxx>]

At Mon, 07 Feb 2011 13:13:18 +0900 (JST),
Ryusuke Konishi wrote:
> 
> On Mon, 07 Feb 2011 12:49:31 +0900, Jiro SEKIBA <jir@xxxxxxxxx> wrote:
> > 
> > At Sun, 06 Feb 2011 21:34:53 +0900 (JST),
> > Ryusuke Konishi wrote:
> > > 
> > > On Sun,  6 Feb 2011 21:24:17 +0900, Ryusuke Konishi wrote:
> > > > Fixes the following error on shutdown:
> > > > 
> > > > Traceback (most recent call last):
> > > >   File "./nilfs2_ss_manager", line 211, in <module>
> > > >     mainloop.run()
> > > > TypeError: __exit__() takes exactly 1 argument (4 given)
> > > > 
> > > > Signed-off-by: Ryusuke Konishi <ryusuke@xxxxxxxx>
> > > 
> > > There is a typo on the previous patch.
> > > 
> > > Please apply the following one instead.
> > 
> > Did you mean "follwoing" as "will send a new mail followed by this"
> > or as "new patch contained in bottom of this mail" ?
> 
> I mean "new patch contained in bottom of this mail."
> 
> The second patch just fixes a typo "execinfo" -> "excinfo", where
> "exc" is abbreviation of "exception" (not "execution").

Ah, I got it.

I applied this one and former series patches.

Thank you!

regards,

> Regards,
> Ryusuke Konishi
> 
>  
> > Because the patch in the mail looks same one with before to me.
> > If you don't mind, I'll fix the bug by myself.
> > 
> > Thank you anyway for the fix!
> > 
> > regards,
> > 
> > > Thanks,
> > > Ryusuke Konishi
> > > --
> > > From: Ryusuke Konishi <ryusuke@xxxxxxxx>
> > > 
> > > nilfs2_ss_manager: fix TypeError at exit
> > > 
> > > Fixes the following error on shutdown:
> > > 
> > > Traceback (most recent call last):
> > >   File "./nilfs2_ss_manager", line 211, in <module>
> > >     mainloop.run()
> > > TypeError: __exit__() takes exactly 1 argument (4 given)
> > > 
> > > Signed-off-by: Ryusuke Konishi <ryusuke@xxxxxxxx>
> > > ---
> > >  nilfs2_ss_manager/nilfs2_ss_manager |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/nilfs2_ss_manager/nilfs2_ss_manager b/nilfs2_ss_manager/nilfs2_ss_manager
> > > index 5821e2a..2243034 100755
> > > --- a/nilfs2_ss_manager/nilfs2_ss_manager
> > > +++ b/nilfs2_ss_manager/nilfs2_ss_manager
> > > @@ -150,7 +150,7 @@ class NODaemonContext:
> > >      def __enter__(self):
> > >          pass
> > >  
> > > -    def __exit__(self):
> > > +    def __exit__(self, *excinfo):
> > >          pass
> > >  
> > >  def register_sighandlers(managers, mainloop):
> > > -- 
> > > 1.7.2.3
> > > 
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
> > > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > > 
> > > 
> > > 
> > 
> > 
> > 
> > 
> > -- 
> > Jiro SEKIBA <jir@xxxxxxxxx>
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
> 


-- 
Jiro SEKIBA <jir@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nilfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html