- Subject: Re: [PATCH 2/2] NFS: Combine the idmapper key types
- From: David Howells <dhowells@xxxxxxxxxx>
- Date: Tue, 31 Jul 2012 15:45:46 +0100
- Cc: dhowells@xxxxxxxxxx, Trond.Myklebust@xxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, steved@xxxxxxxxxx, jlayton@xxxxxxxxxx
- In-reply-to: <501037B6.9080800@netapp.com>
- Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903
- References: <501037B6.9080800@netapp.com> <20120725155336.24392.25186.stgit@warthog.procyon.org.uk> <20120725155347.24392.44505.stgit@warthog.procyon.org.uk>
Bryan Schumaker <bjschuma@xxxxxxxxxx> wrote:
> > + /* Use the non-legacy route unless given auxiliary data */
> > + if (!aux)
> > + return call_sbin_request_key(cons, op, aux);
>
> struct idmap-s are created when the server is mounted, so I don't think "aux" will ever be null here.
I've posted a new version of the patches with this fixed and with
nfs_idmap_upcall() restructured a bit so as not to do the allocations if we
don't have to.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Linux USB Development]
[Linux Media Development]
[Video for Linux]
[Linux NILFS]
[Linux Audio Users]
[Photo]
[Yosemite Info]
[Yosemite Photos]
[POF Sucks]
[Linux Kernel]
[Linux SCSI]
[XFree86]