Re: [PATCH] NFSv2: EOF incorrectly set on short read

[Malahal Naineni <malahal@xxxxxxxxxx>]

Sachin Prabhu [sprabhu@xxxxxxxxxx] wrote:
> In cases where the server returns fewer bytes then those requested, we
> can incorrectly set the eof flag for the file. Fixing this allows the
> request to be retried with updated offset and count arguments.
> 
> Signed-off-by: Sachin Prabhu <sprabhu@xxxxxxxxxx>
> ---
>  fs/nfs/proc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/nfs/proc.c b/fs/nfs/proc.c
> index a706b6b..617c741 100644
> --- a/fs/nfs/proc.c
> +++ b/fs/nfs/proc.c
> @@ -651,7 +651,7 @@ static int nfs_read_done(struct rpc_task *task, struct nfs_read_data *data)
>  		/* Emulate the eof flag, which isn't normally needed in NFSv2
>  		 * as it is guaranteed to always return the file attributes
>  		 */
> -		if (data->args.offset + data->args.count >= data->res.fattr->size)
> +		if (data->args.offset + data->res.count >= data->res.fattr->size)
>  			data->res.eof = 1;
>  	}
>  	return 0;

Good catch!

Regards, Malahal.

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html