Re: [RFC] NFSd laundromat containerization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]




On Fri, 11 May 2012 09:53:07 -0400
"bfields@xxxxxxxxxxxx" <bfields@xxxxxxxxxxxx> wrote:

> On Fri, May 11, 2012 at 05:50:44PM +0400, Stanislav Kinsbursky wrote:
> > Hello.
> > I'm currently looking on NFSd laundromat work, and it looks like
> > have to be performed per networks namespace context.
> > It's easy to make corresponding delayed work per network namespace
> > and thus gain per-net data pointer in laundromat function.
> > But here a problem appears: network namespace is required to skip
> > clients from other network namespaces while iterating over global
> > lists (client_lru and friends).
> > I see two possible solutions:
> > 1) Make these list per network namespace context. In this case
> > network namespace will not be required - per-net data will be
> > enough.
> > 2) Put network namespace link on per-net data (this one is easier, but uglier).
> 
> I'd rather there be as few shared data structures between network
> namespaces as possible--I think that will simplify things.
> 
> So, of those two choices, #1.
> 

Agreed, that's sort of how I envisioned things going. In general,
you'll want to move things that were one global structures to struct
nfsd_net, and fix up the code to manage that on a per-ns basis.

The catch here is that the laundromat is somewhat intertwined with the
grace period, and you need to consider how to handle the grace period
between different namespaces. Do we keep a single grace period
per-machine as we have today? Or do we move to a per-ns grace period
that is started whenever someone starts up knfsd within the container?

-- 
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Photo]     [Yosemite Info]    [Yosemite Photos]    [POF Sucks]     [Linux Kernel]     [Linux SCSI]     [XFree86]

Add to Google Powered by Linux