Re: [PATCH 3/6] nfsd4: preserve __user annotation on cld downcall msg

[Jeff Layton <jlayton@xxxxxxxxxx>]

On Tue,  1 May 2012 11:45:46 -0400
"J. Bruce Fields" <bfields@xxxxxxxxxx> wrote:

> From: "J. Bruce Fields" <bfields@xxxxxxxxxx>
> 
> Cc: Jeff Layton <jlayton@xxxxxxxxxx>
> Signed-off-by: J. Bruce Fields <bfields@xxxxxxxxxx>
> ---
>  fs/nfsd/nfs4recover.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c
> index 2b8e9a9..260d8c8 100644
> --- a/fs/nfsd/nfs4recover.c
> +++ b/fs/nfsd/nfs4recover.c
> @@ -570,7 +570,7 @@ static ssize_t
>  cld_pipe_downcall(struct file *filp, const char __user *src, size_t mlen)
>  {
>  	struct cld_upcall *tmp, *cup;
> -	struct cld_msg *cmsg = (struct cld_msg *)src;
> +	struct cld_msg __user *cmsg = (struct cld_msg __user *)src;
>  	uint32_t xid;
>  	struct nfsd_net *nn = net_generic(filp->f_dentry->d_sb->s_fs_info,
>  						nfsd_net_id);

Good catch...

Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html