Re: [PATCH RFC] vfs: make fstatat retry on ESTALE errors from getattr call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Jeff Layton wrote:

   	error = user_path_at(dfd, filename, lookup_flags, &path);
   	if (error)
   		goto out;
   	error = vfs_getattr(path.mnt, path.dentry, stat);
  +	should_retry = error == -ESTALE ? retry_estale(path.dentry) : false;
  +	if (should_retry) {
  +		lookup_flags |= LOOKUP_REVAL;
  +		goto retry;
  +	}
   	return error;

This is starting to look like FORTRAN.  Maybe turn this into a "do while"?
Then you could make the "goto out" into a break and get rid of them both.
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

[Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Photo]     [Yosemite Info]    [Yosemite Photos]    [POF Sucks]     [Linux Kernel]     [Linux SCSI]     [XFree86]

Add to Google Powered by Linux