Re: [PATCH] Check for beginning '/' in the mount path

[NeilBrown <neilb@xxxxxxx>]

On Fri, 3 Feb 2012 13:15:12 +0200 Boaz Harrosh <bharrosh@xxxxxxxxxxx> wrote:

> On 02/03/2012 03:42 AM, Malahal Naineni wrote:
> > NFSv4 gladly accepts and mounts "hostname:path" instead of
> > "hostname:/path". This causes mount entry mistmatch between /etc/mtab
> > and /proc/mounts files. The former will have "hostname:path" but the
> > latter will have "hostname:/path". This causes umount not work at all.
> > 
> 
> NACK
> 
> like it or not you are changing ABI. Bunch of systems will not work now.
> 
> Also some other NFS servers/clients support it fine. Actually some servers
> make it a special case. (It's called mount by tag)
> 
> The bug is else where fix it there. Either add the preceding '/' to
> /etc/mtab or remove it from /proc/mounts (I prefer the later). Or
                                            ^^^^^^^^^^^^^^^^^^
> fix umount to work with that case.

Agreed.  And while we are at it we should remove the trailing '/' too.
If you
  mount host:/path /somewhere
/proc/mounts will show
    host:/path/

which also confused mount.

NeilBrown

Attachment: signature.asc
Description: PGP signature