- Subject: Re: [PATCH] ata: Don't use NO_IRQ in pata_of_platform driver
- From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
- Date: Mon, 5 Dec 2011 19:15:46 +0100
- Cc: Nicolas Pitre <nicolas.pitre@xxxxxxxxxx>, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Anton Vorontsov <cbouatmailru@xxxxxxxxx>, Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, devicetree-discuss@xxxxxxxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, linux-ide@xxxxxxxxxxxxxxx, Randy Dunlap <rdunlap@xxxxxxxxxxxx>, linux-next@xxxxxxxxxxxxxxx, Ingo Molnar <mingo@xxxxxxx>, Jeff Garzik <jgarzik@xxxxxxxxxx>, Pawel Moll <pawel.moll@xxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
- In-reply-to: <20111205180253.GB29812@localhost.localdomain>
- References: <20111110162859.GA7088@oksana.dev.rtsoft.ru> <20111202192618.GC3037@localhost.localdomain> <CA+55aFwekNWz+V4440f=2iu_BfOxSg0NjVogv4cZZDFbJBNoAQ@mail.gmail.com> <1322867573.11728.22.camel@pasglop> <20111205161157.GA27550@localhost.localdomain> <alpine.LFD.2.02.1112051236350.2357@xanadu.home> <20111205180253.GB29812@localhost.localdomain>
On Mon, Dec 5, 2011 at 19:02, Dave Martin <dave.martin@xxxxxxxxxx> wrote:
> Unfortunately, NO_IRQ is often not spelled "NO_IRQ". It looks like the assumption
> "irq < 0 === no irq" may be quite a lot more widespread than "NO_IRQ === no irq".
Can we make irq unsigned, and hope the compiler catches all of them
(comparison always
false blah blah blah)?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-next" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
[Linux USB Devel]
[Video for Linux]
[Linux Audio Users]
[Photo]
[Yosemite News]
[Yosemite Photos]
[Free Online Dating]
[Linux Kernel]
[Linux SCSI]
[XFree86]