Re: [PATCH 1/2 v2] Add CC_CHECK_LDFLAGS_APPEND m4 macro.

[Lucas De Marchi <lucas.demarchi@xxxxxxxxxxxxxx>]

Hi Kay,

On Fri, Mar 16, 2012 at 9:09 AM, Kay Sievers <kay@xxxxxxxx> wrote:
> On Fri, Mar 16, 2012 at 06:01, Randy Witt <rewitt@xxxxxxxxxxxxxxx> wrote:
>> This is mostly just preparation for the next patch. But this macro is
>> used for flags that are only needed during linking but that don't
>> make sense for normal compilation.
>>
>> I saw this exact type of patch online for systemd, but it never seems to
>> have actually been incorporated into their attributes.m4.
>
>>      LDFLAGS="$ac_save_LDFLAGS"
>
> Mangling CFLAGS or LDFLAGS variables directly with the build-systemd
> is kind of broken. These variables should not be touched, and be
> entirely left alone in control of the user. Systemd is wrong to do
> that, we should not copy that model as it is.
>
> See here:
>  http://www.gnu.org/software/automake/manual/html_node/User-Variables.html
>
> We should rather assign our own variable name with the test/evaluation
> and add our own variable later to AM_* instead.


After reading this page I agree with you. But with this patch we are
not worse than we were before, kind the opposite. And this issue can
be solved by a later patch.

If you are going to prepare a patch for systemd, let me know and I'll copy it :)


Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-modules" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html