Re: [PATCH 1/3 v2] testsuite: ship testsuite/rootfs unzipped

[Lucas De Marchi <lucas.demarchi@xxxxxxxxxxxxxx>]

Hi Dan,

On Thu, Feb 23, 2012 at 3:59 AM, Dan McGee <dan@xxxxxxxxxxxxx> wrote:
> On Wed, Feb 22, 2012 at 11:56 PM, Dan McGee <dan@xxxxxxxxxxxxx> wrote:
>> The current configuration is dumb in any number of ways:
>> 1) If the rationale was for space savings, it works the opposite- the
>>   git repo gets more bloated because we are adding binary compressed
>>   blobs that share little in common with their parent, and anyone that
>>   wants to run the test suite has to unzip it anyway.
>> 2) It is a pain in the butt to add new tests, and not accidentally lose
>>   any new rootfs you built in the directory.
>> 3) `git status` won't help you if you are tweaking files in the rootfs
>>   and don't know they have been changed, or if some test did that and
>>   you couldn't detect it.
>> 4) `git log` won't help you find out what is changing in the rootfs test
>>   directory itself when changes are made to the binary blob, such as
>>   new files being added or even existing files being tweaked.
>> 5) The files just aren't that big anyway- 2.7MB unzipped.


How do you handle the case in which a file needs to be deleted in the
rootfs? E.g:

./testsuite/test-foo
-> it deletes testsuite/rootfs/foo/sys/module/asdf/initstate
./testsuite/test-foo
-> test fails because it assumes module was not loaded

You can't call "git checkout" because you need to run testsuite with
the distributed tarball.


Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-modules" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html