Re: [PATCH] modprobe does not print out dependee module falures.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Fri, 2010-01-29 at 23:01 +0000, Matthew W. S. Bell wrote:
> When a failure occurs loading a dependee module, an error for this is
> not printed, but an incorrect error is printed for each dependent
> module. This patch changes this.

I see what you're trying to solve here, but the existing code has to
handle the case of loading multiple modules by means of dependencies
*and* in the case that -a is specified on the command line. I am
thinking the following:

-               if ((error != warn) || (verbose))
+               if (!all || verbose)
                        error("Error inserting %s (%s): %s\n",
                              mod->modname, mod->filename,

Needs to be:

if ((!all && (error != warn)) || (verbose))


To unsubscribe from this list: send the line "unsubscribe linux-modules" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

[Home]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Video Projectors]     [PDAs]     [Free Online Dating]     [Hacking TiVo]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Devices]     [Big List of Linux Books]     [16.7MP]

Add to Google Powered by Linux