Re: [PATCH] modprobe: Ignore custom install commands if module_in_kernel() doesn't work
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]|
Hello, On pirmadienis 28 Rugsėjis 2009 23:30:39 Alan Jenkins wrote: > Hi, I've fixed some problems I found with the patch you suggested. Is > it ok to include your Signed-off-by on this version, to credit you for > the idea and the original patch? Is this a replacement for 0001-Ignore-custom-install-commands-if-failed-to- find-whe.patch ? Then I do not agree with warn("Failed to read /sys/module/*/initstate.\n"); message. module_in_kernel() might fail due to other reasons. What is more, judging by the warning content above, you do not intend to apply 0002-Get-module-initstate-from-proc-modules-if-it-is-not-.patch , do you? Well, I don't have strong feelings about whether or not /proc should be scanned on older (<= 2.6.19) kernels, but another problem is that current module_in_kernel() will NOT return -1 if initstate is not present (it will return 0). That's what 0002 patch fixes among added /proc scanning. So even with the patch you attached, fork-bombing bug will not be solved. 0002 patch was supposed to be the main patch which fixes the bug, 0001 was just an additional tweak... I will agree with my Signed-off-by on your patch if you let me see (and test) the patch first. My only interest here is to get the fork bombing bug solved... 1. http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=524940#89 -- Modestas Vainius <modestas@xxxxxxxxxx>
Description: This is a digitally signed message part.