Re: [GIT PULL request] ELF rewrite part 2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Hi Andreas, I'm trying to take a more detailed look at your patches. I
have a couple more comments about part 1.

"depmod: separate symbol lookup and dependency calculation"

In load_dep_syms(), why is strtbl_add() not checked using NOFAIL?


"depmod: move tables from struct module into separate struct"

in fetch_tables():

+	tables->pci_table = NULL;
...
+	tables->of_table = NULL;

now tables is a separate struct, all these assignments could be
replaced with a single memset(tables, 0x00, sizeof(struct
module_tables)).

Thanks
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-modules" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Home]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Video Projectors]     [PDAs]     [Free Online Dating]     [Hacking TiVo]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Devices]     [Big List of Linux Books]     [16.7MP]

Add to Google Powered by Linux