Re: dw_mmc: priv->sdr_timing set wrong

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 22, 2013 at 12:15 PM, Jaehoon Chung <jh80.chung@xxxxxxxxxxx> wrote:
> Hi Grant,
>
> Good catch..sdr-timing is set to wrong value.(set to ddr-timing)
> Do you have the plan that send the fixing patch at mailing?
Oops..
Grant, Thanks for pointing out this.I will prepare the fix and send soon.
>
> Best Regards,
> Jaehoon Chung
>
> On 10/19/2013 05:13 AM, Grant Grundler wrote:
>> Chris, Yuvaraj, Alim, Jaehoon,
>>
>> This patch is wrong:
>> https://git.kernel.org/cgit/linux/kernel/git/cjb/mmc.git/commit/?h=mmc-next&id=e6c784eded7b39caeaf2e9206336fa1daeccfd09
>>
>> sdr_timing needs to come from the of_property "samsung,dw-mshc-sdr-timing".
>> Assignment of priv->sdr_timing needs to move back where it was before.
>>
>> Can one of you guys "just fix it" or do you need a patch from me (or Sonny)?
>>
>> (This came up during my review of eMMC patches that sonny is
>> backporting to ChromeOS-3.8 kernel and I'm not done yet - have a ton
>> more to do here.)
>>
>> thanks,
>> grant
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux