Re: [PATCH v2] mmc: tmio: Don't access hardware registers after stopping clocks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Jun 13 2012, Guennadi Liakhovetski wrote:
> On Tue, 12 Jun 2012, Laurent Pinchart wrote:
>
>> The tmio_mmc_set_ios() function configures the MMC power, clock and bus
>> width. When the mmc core requests the driver to power off the card, we
>> inform runtime PM, that the controller can be suspended. This can lead
>> to the MSTP clock being turned off.
>> 
>> Writing to any 16-bit hardware registers with the MSTP clock off leads
>> to timeouts and errors being printed to the kernel log. This can occur
>> both when stopping the MMC clock and when configuring the bus width.
>> 
>> To fix this, stop the MMC clock before calling put_runtime_pm(), and
>> skip bus width configuration when power is off.
>> 
>> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>
> Acked-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>

Thanks, pushed to mmc-next for 3.6.

- Chris.
-- 
Chris Ball   <cjb@xxxxxxxxxx>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux