Re: [PATCH v2] slab+slob: dup name string

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 05/22/2012 05:58 PM, Christoph Lameter wrote:
On Tue, 22 May 2012, Glauber Costa wrote:

[ v2: Also dup string for early caches, requested by David Rientjes ]

kstrdups that early could cause additional issues. Its better to leave
things as they were.


For me is really all the same. But note that before those kstrdups, we do a bunch of kmallocs as well already. (ex:

/* 4) Replace the bootstrap head arrays */
{
	struct array_cache *ptr;

	ptr = kmalloc(sizeof(struct arraycache_init), GFP_NOWAIT);

Which other point of issues do you see besides the memory allocation done by strdup?

I agree with your comment that we shouldn't worry about those caches, because only init code uses it.

Weather or not David's concern of wanting to delete those caches some day is valid, I'll leave up to you guys to decide

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>


[Site Home]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Tools]     [DDR & Rambus]     [Asterisk Internet PBX]     [Linux API]     [Monitors]

Add to Google Google PageRank Checking tool