Re: [PATCH 2/2] mm: memblock - Handled failure of debug fs entries creation
|[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
On Sun, 29 Apr 2012 00:32:26 +0530 Sasikanth babu <sasikanth.v19@xxxxxxxxx> wrote:Excellent!
> > Fact is, debugfs_create_dir() and debugfs_create_file() are stupid
> > interfaces which don't provide the caller (and hence the user) with any
> > information about why they failed. Perhaps memblock_init_debugfs()
> > should return -EWESUCK.
> I'm working on a patch which address this issue. debugfs_create_XXX
> will return proper error codes, and fixing the existing code not each
> and every part but the code
> which handles the values returned by debufs_create_XXX otherwise it will
> break the existing
> functionality .
Well, don't modify the existing interfaces: create new ones and we can
> (any suggestions or opinions ?)
migrate gradually. But you're probably already doing that.