- To: linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx
- Subject: [PATCH 22/39] autonuma: select_task_rq_fair cleanup new_cpu < 0 fix
- From: Andrea Arcangeli <aarcange@xxxxxxxxxx>
- Date: Mon, 26 Mar 2012 19:46:09 +0200
- Cc: Hillf Danton <dhillf@xxxxxxxxx>, Dan Smith <danms@xxxxxxxxxx>, Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Paul Turner <pjt@xxxxxxxxxx>, Suresh Siddha <suresh.b.siddha@xxxxxxxxx>, Mike Galbraith <efault@xxxxxx>, "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx>, Lai Jiangshan <laijs@xxxxxxxxxxxxxx>, Bharata B Rao <bharata.rao@xxxxxxxxx>, Lee Schermerhorn <Lee.Schermerhorn@xxxxxx>, Rik van Riel <riel@xxxxxxxxxx>, Johannes Weiner <hannes@xxxxxxxxxxx>
- Delivered-to: linux-mm-outgoing@xxxxxxxxx
- Delivered-to: int-list-linux-mm@xxxxxxxxx
- Delivered-to: linux-mm@xxxxxxxxx
- In-reply-to: <1332783986-24195-1-git-send-email-aarcange@redhat.com>
Cleanup comment in the case find_idlest_cpu returned -1 and check for
< 0 instead of == -1 as it should allow gcc to generate more optimal
code.
Signed-off-by: Andrea Arcangeli <aarcange@xxxxxxxxxx>
---
kernel/sched/fair.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index a8498e0..0c60f46 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -2792,10 +2792,9 @@ select_task_rq_fair(struct task_struct *p, int sd_flag, int wake_flags)
if (new_cpu == -1 || new_cpu == cpu) {
/* Now try balancing at a lower domain level of cpu */
sd = sd->child;
- if (new_cpu == -1) {
- /* Only for certain that new cpu is valid */
+ if (new_cpu < 0)
+ /* Return prev_cpu is find_idlest_cpu failed */
new_cpu = prev_cpu;
- }
continue;
}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>
[Site Home]
[Linux ARM Kernel]
[Linux ARM]
[Linux Omap]
[Fedora ARM]
[IETF Annouce]
[Security]
[Bugtraq]
[Linux]
[Linux OMAP]
[Linux MIPS]
[ECOS]
[Tools]
[DDR & Rambus]
[Asterisk Internet PBX]
[Linux API]
[Monitors]