Re: [PATCH 3/4] airspy: print notice to point SDR API is not 100% stable yet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Moikka!

On 07/18/2014 08:15 AM, Hans Verkuil wrote:
On 07/18/2014 03:05 AM, Antti Palosaari wrote:
Print notice on driver load: "SDR API is still slightly
experimental and functionality changes may follow". It is just
remind possible used SDR API is very new and surprises may occur.


On that topic: I would like to see a 'buffersize' or 'samples_per_buffer'
field in struct v4l2_sdr_format. That gives applications the opportunity
to 1) get the current buffer size and 2) be able to change it if the driver
supports that. E.g. for high sampling rates they might want to use larger
buffers, for low they might want to select smaller buffers.

Right now it is fixed and you won't know the buffer size until you do
QUERYBUF. Which is not in sync with what other formats do.

I understand what you mean. If you use mmap or userptr then you would like to really know how much data you will get per buffer, but if you use read then it has no meaning.

I prefer 'buffersize' over 'samples_per_buffer', just because some formats are very complex, packed and compressed, and calculating 'buffersize' from 'samples_per_buffer' could be quite complex.

It is also possible report both, but then you should decide how handle situation on S_FMT. Another should be zero and driver uses the one which has value !zero.


regards
Antti

--
http://palosaari.fi/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux