Re: [PATCH] [media] mantis: merge both vp2033 and vp2040 drivers

[Manu Abraham <abraham.manu@xxxxxxxxx>]

On Tue, Aug 7, 2012 at 12:32 AM, Mauro Carvalho Chehab
<mchehab@xxxxxxxxxx> wrote:
> As noticed at:
>         http://comments.gmane.org/gmane.linux.drivers.video-input-infrastructure/48034
>
> Both drivers are identical, except for the name. So, there's no
> sense on keeping both. Instead of forking the entire code, just
> fork the vp3033_config struct, saving some space, and cleaning
> up the Kernel.

>
> Reported-by: Igor M. Liplianin <liplianin@xxxxx>
> Cc: Manu Abraham <abraham.manu@xxxxxxxxx>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>

Nack.

VP-2033 and 2040 are both different in terms of hardware. If someone
wants to add
in additional frontend characteristic differences, he shouldn't have
to add in this code
again.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html