Re: [PATCH] lmedm04 v2.05 conversion to dvb-usb-v2

[Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>]

Em 05-08-2012 11:10, Malcolm Priestley escreveu:
> Conversion of lmedm04 to dvb-usb-v2
> 
> functional changes are that callbacks have been moved to fe_ioctl_override.

Don't do that: fe_ioctl_override has a broken design and only handles DVBv3
ioctl's. So, if userspace is using DVBv5, this will cause a regression.

Antti,

IMO, the best thing to do is to either remove fe_ioctl_override or to print
a warning when a driver calls it, in order to warn developers that they're
using a legacy callback that could cause the driver to not work properly.

Regards,
Mauro

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html