[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] em28xx: Fix height setting on non-progressive captures



This was introduced on commit c2a6b54a9:
"em28xx: fix: don't do image interlacing on webcams"
It is a known bug that has already been reported several times
and confirmed by Mauro.
Tested by compilation only.

Signed-off-by: Ezequiel Garcia <elezegarcia@xxxxxxxxx>
---
Hi,

I have no idea why this hasn't been fixed before.

See this mail for Mauro's confirmation
http://www.digipedia.pl/usenet/thread/18550/7691/#post7685
where he requested a patch on reporter. 

I guess the patch never came in.

Regards,
Ezequiel.
---
 drivers/media/video/em28xx/em28xx-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/em28xx/em28xx-core.c b/drivers/media/video/em28xx/em28xx-core.c
index de2cb20..6daa861 100644
--- a/drivers/media/video/em28xx/em28xx-core.c
+++ b/drivers/media/video/em28xx/em28xx-core.c
@@ -786,7 +786,7 @@ int em28xx_resolution_set(struct em28xx *dev)
 		dev->vbi_height = 18;
 
 	if (!dev->progressive)
-		height >>= norm_maxh(dev);
+		height = height / 2;
 
 	em28xx_set_outfmt(dev);
 
-- 
1.7.4.4

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux Input]     [Video for Linux]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Photos]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Devices]     [Yosemite Backpacking]

Add to Google Powered by Linux