RE: [PATCH] [media] videobuf-dma-contig: restore buffer mapping for uncached bufers

["Lad, Prabhakar" <prabhakar.lad@xxxxxx>]

Hi Hans,

On Mon, Jun 25, 2012 at 17:13:39, Hans Verkuil wrote:
> On Sat 23 June 2012 11:19:24 Hans Verkuil wrote:
> > On Fri June 22 2012 18:53:27 Federico Vaga wrote:
> > > In data venerdì 22 giugno 2012 18:45:31, Hans Verkuil ha scritto:
> > > > On Fri June 22 2012 17:28:04 Federico Vaga wrote:
> > > > > > from commit a8f3c203e19b702fa5e8e83a9b6fb3c5a6d1cce4
> > > > > > restore the mapping scheme for uncached buffers,
> > > > > > which was changed in a common scheme for cached and uncached.
> > > > > > This apparently was wrong, and was probably intended only for
> > > > > > cached
> > > > > > buffers. the fix fixes the crash observed while mapping uncached
> > > > > > buffers.
> > > > > > 
> > > > > > Signed-off-by: Lad, Prabhakar <prabhakar.lad@xxxxxx>
> > > > > > Signed-off-by: Hadli, Manjunath <manjunath.hadli@xxxxxx>
> > > > > 
> > > > > Acked-by: Federico Vaga <federico.vaga@xxxxxxxxx>
> > > > > 
> > > > > I tested the patch on the STA2X11 board.
> > > > 
> > > > Was this patch ever posted on linux-media? I didn't see it on the
> > > > mailinglist, nor in my personal inbox.
> > > > 
> > > > Perhaps something went wrong?
> > > 
> > > I recived the email as CC and linux-media was the main destination.
> > > Davinci list was also added as CC and you can find the patch there:
> > > 
> > > http://www.mail-archive.com/davinci-linux-open-
> > > source@xxxxxxxxxxxxxxxxxxxx/msg22998.html
> > > 
> > > Something went wrong.
> > 
> > Weird, it never ended up at the linux-media mailinglist (not just me, it's
> > not in the linux-media archives either).
> > 
> > Anyway, I'll test this on Monday and if it works fine for me as well I'll Ack it.
> 
> I've tested this patch, and it looks good:
> 
> Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> 
> Prabhakar: Please post this again with all acks and marked as [PATCH for v3.5] to the
> linux-media mailinglist asap. This patch never made it to this list for some reason,
> so make sure it gets there this time.
>  
  Ok. Thanks for the review.

Thx,
--Prabhakar Lad

> Regards,
> 
> 	Hans
> 
> > 
> > Regards,
> > 
> > 	Hans
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-media" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html