[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFCv1 PATCH 18/32] v4l2-ioctl.c: finalize table conversion.



On Mon June 18 2012 11:46:57 Laurent Pinchart wrote:
> Hi Hans,
> 
> Thanks for the patch.
> 
> On Sunday 10 June 2012 12:25:40 Hans Verkuil wrote:
> > From: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> > 
> > Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> > ---
> >  drivers/media/video/v4l2-ioctl.c |   35 +++++++++++++----------------------
> > 1 file changed, 13 insertions(+), 22 deletions(-)
> > 
> > diff --git a/drivers/media/video/v4l2-ioctl.c
> > b/drivers/media/video/v4l2-ioctl.c index 0de31c4..6c91674 100644
> > --- a/drivers/media/video/v4l2-ioctl.c
> > +++ b/drivers/media/video/v4l2-ioctl.c
> > @@ -870,6 +870,11 @@ static void v4l_print_newline(const void *arg)
> >  	pr_cont("\n");
> >  }
> > 
> > +static void v4l_print_default(const void *arg)
> > +{
> > +	pr_cont("non-standard ioctl\n");
> 
> I'd say "driver-specific ioctl" instead. "non-standard" may sound like an 
> error to users.

Much better, thank you!

Regards,

	Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux Input]     [Video for Linux]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Photos]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Devices]     [Yosemite Backpacking]

Add to Google Powered by Linux