Re: [RFCv1 PATCH 27/32] vivi: embed struct video_device instead of allocating it.

[Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>]

Hi Hans,

Thanks for the patch.

On Sunday 10 June 2012 12:25:49 Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> 
> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
> ---
>  drivers/media/video/vivi.c |   25 +++++++------------------
>  1 file changed, 7 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/media/video/vivi.c b/drivers/media/video/vivi.c
> index 8dd5ae6..1e4da5e 100644
> --- a/drivers/media/video/vivi.c
> +++ b/drivers/media/video/vivi.c

[snip]

> @@ -1080,7 +1078,6 @@ static int vidioc_enum_input(struct file *file, void
> *priv, return -EINVAL;
> 
>  	inp->type = V4L2_INPUT_TYPE_CAMERA;
> -	inp->std = V4L2_STD_525_60;

Doesn't this belong to the previous patch ?

>  	sprintf(inp->name, "Camera %u", inp->index);
>  	return 0;
>  }

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html