[PATCH 1/2] [BUG] dvb_usb_v2: return the download ret in dvb_usb_download_firmware

[Malcolm Priestley <tvboxspy@xxxxxxxxx>]

Hi antti

There some issues with dvb_usb_v2 with the lmedm04 driver.

The first being this patch, no return value from dvb_usb_download_firmware
causes system wide dead lock with COLD disconnect as system attempts to continue
to warm state.

The second is to do with d->props.bInterfaceNumber in patch 2.

In get_usb_stream_config there no handing of the struct dvb_frontend.
...
int (*get_usb_stream_config) (struct dvb_frontend *,
			struct usb_data_stream_properties *);

...
I wonder if it would be better to use adapter instead?

I also have a draft patch to use delayed work.

Regards


Malcolm


Signed-off-by: Malcolm Priestley <tvboxspy@xxxxxxxxx>
---
 drivers/media/dvb/dvb-usb/dvb_usb_init.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/dvb/dvb-usb/dvb_usb_init.c b/drivers/media/dvb/dvb-usb/dvb_usb_init.c
index 60aa944..c16a28a 100644
--- a/drivers/media/dvb/dvb-usb/dvb_usb_init.c
+++ b/drivers/media/dvb/dvb-usb/dvb_usb_init.c
@@ -61,7 +61,7 @@ static int dvb_usb_download_firmware(struct dvb_usb_device *d)
 	if (ret < 0)
 		goto err;
 
-	return 0;
+	return ret;
 err:
 	pr_debug("%s: failed=%d\n", __func__, ret);
 	return ret;
-- 
1.7.10











--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html