Re: [PATCH 1/1] v4l: Remove __user from interface structure definitions

[Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>]

Hi Sakari,

On Saturday 26 May 2012 23:07:49 Sakari Ailus wrote:
> The __user macro is not strictly needed in videodev2.h, and it also prevents
> using the header file as such in the user space. __user is already not used
> in many of the interface structs containing pointers.
> 
> Stop using __user in videodev2.h.

Please don't. __user is useful. You should not use kernel headers as-is in 
userspace, they need to be installed use make headers_install first.

> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxx>
> ---
>  include/linux/videodev2.h |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
> index 370d111..c8e1bb0 100644
> --- a/include/linux/videodev2.h
> +++ b/include/linux/videodev2.h
> @@ -708,16 +708,16 @@ struct v4l2_framebuffer {
> 
>  struct v4l2_clip {
>  	struct v4l2_rect        c;
> -	struct v4l2_clip	__user *next;
> +	struct v4l2_clip	*next;
>  };
> 
>  struct v4l2_window {
>  	struct v4l2_rect        w;
>  	__u32			field;	 /* enum v4l2_field */
>  	__u32			chromakey;
> -	struct v4l2_clip	__user *clips;
> +	struct v4l2_clip	*clips;
>  	__u32			clipcount;
> -	void			__user *bitmap;
> +	void			*bitmap;
>  	__u8                    global_alpha;
>  };

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html