Re: [PATCH 3/3] I don`t know for what, but there`s dublicate item.

[Ezequiel Garcia <elezegarcia@xxxxxxxxx>]

Hi,

On Sat, May 26, 2012 at 4:18 PM, Volokh Konstantin <volokh84@xxxxxxxxx> wrote:
> Signed-off-by: Volokh Konstantin <volokh84@xxxxxxxxx>
> ---
>  drivers/media/video/bt8xx/bttv-driver.c |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/video/bt8xx/bttv-driver.c b/drivers/media/video/bt8xx/bttv-driver.c
> index e581b37..b4ee7de 100644
> --- a/drivers/media/video/bt8xx/bttv-driver.c
> +++ b/drivers/media/video/bt8xx/bttv-driver.c
> @@ -558,12 +558,6 @@ static const struct bttv_format formats[] = {
>                .depth    = 16,
>                .flags    = FORMAT_FLAGS_PACKED,
>        },{
> -               .name     = "4:2:2, packed, YUYV",
> -               .fourcc   = V4L2_PIX_FMT_YUYV,
> -               .btformat = BT848_COLOR_FMT_YUY2,
> -               .depth    = 16,
> -               .flags    = FORMAT_FLAGS_PACKED,
> -       },{
>                .name     = "4:2:2, packed, UYVY",
>                .fourcc   = V4L2_PIX_FMT_UYVY,
>                .btformat = BT848_COLOR_FMT_YUY2,
> --
> 1.7.7.6
>

The patch looks correct to me.

But the subject is *very* wrong. You should set it to something like:
"[bt8xx] Remove duplicated pixel format entry".

Also, the subject says [PATCH 3/3], where are the other patches?

As a newbie I used to do this kind of mistakes often. Now I try to let patches
sleep for a couple of days, and then review them once again before send them.

Also send them once to yourself before sending to the list,
so you get another chance to catch mistakes.

Hope it helps,
Ezequiel.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html