[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] stk-webcam: Don't flip the image by default



Hi,

On 04/09/2012 09:27 AM, Jaime Velasco wrote:

2012/4/8 Hans de Goede <hdegoede@xxxxxxxxxx <mailto:hdegoede@xxxxxxxxxx>>

    Prior to this patch the stk-webcam driver was enabling the vflip and mirror
    bits in the sensor by default. Which only is the right thing to do if the
    sensor is actually mounted upside down, which it usually is not.

    Actually we've received upside down reports for both usb-ids which this
    driver supports, one for an "ASUSTeK Computer Inc." "A3H" laptop with
    a build in 174f:a311 webcam, and one for an "To Be Filled By O.E.M."
    "Z96FM" laptop with a build in 05e1:0501 webcam.

    Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx <mailto:hdegoede@xxxxxxxxxx>>


Hi, I don't know hoy many users of stk-webcam could be, but this will surely cause a small regression for them. I agree it seems neater your way, but I don't think it makes sense to half-break the driver for a set of users in order to fix it for another.

I understand where you're coming from, but the vflip/hflip options of the driver
in turn toggle bits in the sensor, which default to no flipping. IOW thse bits
should only be set if a sensor is mounted upside down (or a user explicitly
indicates he wants a flipped image). Likely some of these cameras are found
in Asus laptops, and Asus is well known for mounting some of their laptop
webcam modules upside down, I guess this is where the flip by default behavior
comes from, but that does not make it *right*.

Currently we are getting bug reports from users who have a laptop where the
sensor is mounted the right way up, and they are getting an upside down image...

So either way we are doing the wrong thing for a group of users, and we
are going to need a quirk table in the driver, if we add such a quirk
table I would much rather have it contain entries for laptops which
actually have the camera upside down. Esp. since that is how we are doing
it in all other drivers. It just does not make sense to flip by default, and
then keep a list of non buggy laptops, and change the flipping behavior there ...

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux Input]     [Video for Linux]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Photos]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Devices]     [Yosemite Backpacking]

Add to Google Powered by Linux