[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] stk-webcam: Don't flip the image by default



Sorry, resending message. Hopefully it gets to the list now. I blame gmail...

2012/4/9 Jaime Velasco <jsagarribay@xxxxxxxxx>
>
>
> 2012/4/8 Hans de Goede <hdegoede@xxxxxxxxxx>
>>
>> Prior to this patch the stk-webcam driver was enabling the vflip and
>> mirror
>> bits in the sensor by default. Which only is the right thing to do if the
>> sensor is actually mounted upside down, which it usually is not.
>>
>> Actually we've received upside down reports for both usb-ids which this
>> driver supports, one for an "ASUSTeK Computer Inc." "A3H" laptop with
>> a build in 174f:a311 webcam, and one for an "To Be Filled By O.E.M."
>> "Z96FM" laptop with a build in 05e1:0501 webcam.
>>
>> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
>
>
> Hi, I don't know hoy many users of stk-webcam could be, but this will
> surely cause a small regression for them. I agree it seems neater your way,
> but I don't think it makes sense to half-break the driver for a set of users
> in order to fix it for another.
>
> That said, if you feel this is the way to go I won't complain. My old
> laptop broke some years ago and I have not touch nor used this driver since.
>
> Regards,
> Jaime
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux Input]     [Video for Linux]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Photos]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Devices]     [Yosemite Backpacking]

Add to Google Powered by Linux