Re: [PATCH 1/2] v4l2: standardize log start/end message.

[Sylwester Nawrocki <snjw23@xxxxxxxxx>]

Hello Hans,

On 01/27/2012 06:59 PM, Hans Verkuil wrote:
> diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c
> index d0d7281..2348669 100644
> --- a/drivers/media/video/v4l2-ioctl.c
> +++ b/drivers/media/video/v4l2-ioctl.c
> @@ -1911,7 +1911,15 @@ static long __video_do_ioctl(struct file *file,
>   	{
>   		if (!ops->vidioc_log_status)
>   			break;
> +		if (vfd->v4l2_dev)
> +			printk(KERN_INFO
> +				"%s: =================  START STATUS  =================\n",
> +				vfd->v4l2_dev->name);
>   		ret = ops->vidioc_log_status(file, fh);
> +		if (vfd->v4l2_dev)
> +			printk(KERN_INFO
> +				"%s: ==================  END STATUS  ==================\n",
> +				vfd->v4l2_dev->name);

Nice cleanup, but wouldn't it be more appropriate to use pr_info() here
instead ? AFAIK this is preferred logging style now.

--

Thanks,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html