Re: [PATCH 1/3] m88brs2000 DVB-S frontend and tuner module.

[Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>]

Em 22-01-2012 08:38, Malcolm Priestley escreveu:
> Support for m88brs2000 chip used in lmedm04 driver.
> 
> Note there are still lock problems.
> 
> Slow channel change due to the large block of registers sent in set_frontend.
> 
> Signed-off-by: Malcolm Priestley <tvboxspy@xxxxxxxxx>
> ---

...
> +static int m88rs2000_set_property(struct dvb_frontend *fe,
> +	struct dtv_property *p)
> +{
> +	dprintk("%s(..)\n", __func__);
> +	return 0;
> +}
> +
> +static int m88rs2000_get_property(struct dvb_frontend *fe,
> +	struct dtv_property *p)
> +{
> +	dprintk("%s(..)\n", __func__);
> +	return 0;
> +}
...

Just don't implement set_property/get_property if you're not using them.

Except for that, the code looks ok on my eyes.

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html