Re: [PATCH 2/6] v4l2-event: Deny subscribing with a type of V4L2_EVENT_ALL

[Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>]

Hi Hans,

On Thursday 27 October 2011 13:17:59 Hans de Goede wrote:
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>

This brings the code in sync with the documentation, thanks.

Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

> ---
>  drivers/media/video/v4l2-event.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/video/v4l2-event.c
> b/drivers/media/video/v4l2-event.c index 53b190c..9f56f18 100644
> --- a/drivers/media/video/v4l2-event.c
> +++ b/drivers/media/video/v4l2-event.c
> @@ -215,6 +215,9 @@ int v4l2_event_subscribe(struct v4l2_fh *fh,
>  	unsigned long flags;
>  	unsigned i;
> 
> +	if (sub->type == V4L2_EVENT_ALL)
> +		return -EINVAL;
> +
>  	if (elems < 1)
>  		elems = 1;
>  	if (sub->type == V4L2_EVENT_CTRL) {

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html