Re: [RFC] V4L2 API for flash devices

[Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>]

Hi Sakari,

On Monday 28 March 2011 14:55:40 Sakari Ailus wrote:

[snip]

> 	V4L2_CID_FLASH_STROBE_MODE (menu; LED)
> 
> Use hardware or software strobe. If hardware strobe is selected, the
> flash controller is a slave in the system where the sensor produces the
> strobe signal to the flash.
> 
> In this case the flash controller setup is limited to programming strobe
> timeout and power (LED flash) and the sensor controls the timing and
> length of the strobe.
> 
> enum v4l2_flash_strobe_mode {
> 	V4L2_FLASH_STROBE_MODE_SOFTWARE,
> 	V4L2_FLASH_STROBE_MODE_EXT_STROBE,
> };

[snip]

> 	V4L2_CID_FLASH_LED_MODE (menu; LED)
> 
> enum v4l2_flash_led_mode {
> 	V4L2_FLASH_LED_MODE_FLASH = 1,
> 	V4L2_FLASH_LED_MODE_TORCH,
> };

Thinking about this some more, shouldn't we combine the two controls ? They 
are basically used to configure how the flash LED is controlled: manually 
(torch mode), automatically by the flash controller (software strobe mode) or 
automatically by an external component (external strobe mode).

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html