[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] mx2_camera: fix pixel clock polarity configuration



On Wed, 10 Nov 2010, Baruch Siach wrote:

> Hi linux-media,
> 
> On Wed, Oct 27, 2010 at 09:03:52AM +0200, Baruch Siach wrote:
> > When SOCAM_PCLK_SAMPLE_FALLING, just leave CSICR1_REDGE unset, otherwise we get
> > the inverted behaviour.
> > 
> > Signed-off-by: Baruch Siach <baruch@xxxxxxxxxx>
> 
> Trying my luck again. Now adding Guennadi to Cc.

Trying again will not help, until you reply to my previous comment, and 
you, probably, will not reply to it, until your mail-server stops 
rejecting my mails, and it probably will reject this one too in a way 
similar too

<baruch@xxxxxxxxxx>:
62.219.50.35_does_not_like_recipient./Remote_host_said:_550_5.7.1_<baruch@xxxxxxxxxx>..._Rejected_recent_spam_sourc
e_[mailout-de.gmx.net]_Reply_at_http://tk-open-systems.com/unblockme/index.php?id=tango/Giving_up_on_62.219.50.35./

Thanks
Guennadi

> 
> This is a real bug fix, BTW.
> 
> baruch
> 
> > ---
> >  drivers/media/video/mx2_camera.c |    2 --
> >  1 files changed, 0 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c
> > index 3ea2ec0..02f144f 100644
> > --- a/drivers/media/video/mx2_camera.c
> > +++ b/drivers/media/video/mx2_camera.c
> > @@ -811,8 +811,6 @@ static int mx2_camera_set_bus_param(struct soc_camera_device *icd,
> >  
> >  	if (common_flags & SOCAM_PCLK_SAMPLE_RISING)
> >  		csicr1 |= CSICR1_REDGE;
> > -	if (common_flags & SOCAM_PCLK_SAMPLE_FALLING)
> > -		csicr1 |= CSICR1_INV_PCLK;
> >  	if (common_flags & SOCAM_VSYNC_ACTIVE_HIGH)
> >  		csicr1 |= CSICR1_SOF_POL;
> >  	if (common_flags & SOCAM_HSYNC_ACTIVE_HIGH)
> > -- 
> 
> -- 
>                                                      ~. .~   Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
>    - baruch@xxxxxxxxxx - tel: +972.2.679.5364, http://www.tkos.co.il -
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux Input]     [Video for Linux]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Photos]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Devices]     [Yosemite Backpacking]     [Linux Input]

Add to Google Powered by Linux