Re: V4L/DVB/IR patches pending merge

Hernán Ordiales <h.ordiales@xxxxxxxxx> · Fri, 29 Oct 2010 22:15:29 -0300

On Fri, Oct 29, 2010 at 8:24 PM, Antti Palosaari <crope@xxxxxx> wrote:
> On 10/30/2010 02:02 AM, Hernán Ordiales wrote:
>>
>> 2010/10/23 Mauro Carvalho Chehab<mchehab@xxxxxxxxxx>:
>>>
>>> This is the list of patches that weren't applied yet. I've made a big
>>> effort starting
>>> last weekend to handle everything I could. All pull requests were
>>> addressed. There are still
>>> 43 patches on my queue.
>>>
>>> Please help me to clean the list.
>>>
>>> This is what we have currently:
>>
>> [snip]
>>>
>>>                == Waiting for Patrick Boettcher<pboettcher@xxxxxxxxx>
>>>  review ==
>>>
>>> May,25 2010: Adding support to the Geniatech/MyGica SBTVD Stick S870
>>> remote control http://patchwork.kernel.org/patch/102314  Hernán
>>> Ordiales<h.ordiales@xxxxxxxxx>
>>> Jul,14 2010: [1/4] drivers/media/dvb: Remove dead Configs
>>>           http://patchwork.kernel.org/patch/111972  Christian
>>> Dietrich<qy03fugy@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
>>> Jul,14 2010: [2/4] drivers/media/dvb: Remove undead configs
>>>           http://patchwork.kernel.org/patch/111973  Christian
>>> Dietrich<qy03fugy@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
>>>
>>> The first patch is probably broken.
>>>
>>> Hernán,
>>> Could you please re-generate it?
>>
>> Yes, i'm sending it as attachment (regenerated agaisnt trunk, 15168
>> revision)
>>
>> Cheers
>
> Your keytable seems to be wrong since it have both keycode and its
> complement (which is used for error check normally). I think it is NEC
> remote? In that case address byte is typically same for all buttons.

Yes, i know the complement thing . The table was generated by reverse
engineering and i couldn't found the common address so i left in that
way. For example, for '7' button i receive:
dib0700: IR raw 01 01 00 00 07 F8 (len 6)

I think Is not a nec remote, it is a generic one that comes with
mygica/geniatech products. I rebuilt the key table (patch attached)
using '00' as address, is that ok? And leaving it using RC5 protocol
(instead adding a case for dvb_usb_dib0700_ir_proto=1)
in this way works ok too

.   default:
.   .   /* RC5 Protocol */
.   .   poll_reply.report_id  = buf[0];
.   .   poll_reply.data_state = buf[1];
.   .   poll_reply.system     = (buf[2] << 8) | buf[3];
.   .   poll_reply.data       = buf[4];
.   .   poll_reply.not_data   = buf[5];
.   .   break;

+	/* Key codes for the Geniatech/MyGica SBTVD Stick S870 remote
+	   set dvb_usb_dib0700_ir_proto=1 */
+	{ 0x0038, KEY_TV }, /* TV/AV */
+	{ 0x000c, KEY_POWER },
+	{ 0x000a, KEY_MUTE },
+	{ 0x002b, KEY_VOLUMEUP },
+	{ 0x002c, KEY_VOLUMEDOWN },
+	{ 0x0012, KEY_CHANNELUP },
+	{ 0x0013, KEY_CHANNELDOWN },
+	{ 0x0001, KEY_1 },
+	{ 0x0002, KEY_2 },
+	{ 0x0003, KEY_3 },
+	{ 0x0004, KEY_4 },
+	{ 0x0005, KEY_5 },
+	{ 0x0006, KEY_6 },
+	{ 0x0007, KEY_7 },
+	{ 0x0008, KEY_8 },
+	{ 0x0009, KEY_9 },
+	{ 0x0000, KEY_0 },
+	{ 0x0016, KEY_PAUSE },
+	{ 0x0017, KEY_PLAY },
+	{ 0x000b, KEY_STOP },
+	{ 0x0026, KEY_REWIND },
+	{ 0x0027, KEY_FASTFORWARD },
+	{ 0x0029, KEY_ESC },
+	{ 0x001f, KEY_RECORD },
+	{ 0x0020, KEY_UP },
+	{ 0x0021, KEY_DOWN },
+	{ 0x0011, KEY_LEFT },
+	{ 0x0010, KEY_RIGHT },
+	{ 0x000d, KEY_OK },
+	{ 0x001e, KEY_PLAYPAUSE }, /* Timeshift */
+	{ 0x000e, KEY_CAMERA }, /* Snapshot */
+	{ 0x0025, KEY_EPG }, /* Info KEY_INFO */
+	{ 0x002d, KEY_MENU }, /* DVD Menu */
+	{ 0x000f, KEY_SCREEN }, /* Full screen toggle */
+	{ 0x0014, KEY_SHUFFLE },

> Antti
> --
> http://palosaari.fi/
>

-- 
Hernán
http://h.ordia.com.ar