[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] via-camera: fix OLPC serial port check



On Wed, 27 Oct 2010 20:02:28 +0100 (BST)
Daniel Drake <dsd@xxxxxxxxxx> wrote:

> CONFIG_OLPC_XO_1_5 does not exist in mainline, and it's not certain that
> we'll find a reason to add it later.
> 
> We should also be detecting this at runtime, and if we do it at probe
> time we can be sure not to mess around with the PCI config space on XO-1.

This makes every user carry a bit of OLPC-specific code.  But there are
no non-OLPC users currently, the code is small, and we get rid of some
#ifdefs, which is always a good thing.  Seems good to me.

	Acked-by: Jonathan Corbet <corbet@xxxxxxx>

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux Input]     [Video for Linux]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Photos]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Devices]     [Yosemite Backpacking]     [Linux Input]

Add to Google Powered by Linux