Re: man-pages: pthread_sigmask comment / code inconsistency

[Michael Kerrisk <mtk.manpages@xxxxxxxxx>]

Hello Pat,

On Mon, Oct 10, 2011 at 9:53 AM, Pat Pannuto <pat.pannuto@xxxxxxxxx> wrote:
> This is found on both my installed 3.27 and the html 3.32 release
> http://kernel.org/doc/man-pages/online/pages/man3/pthread_sigmask.3.html
>
> In the sample code, the comment indicates blocking SIGINT, while the code
> appears to be blocking SIGQUIT and SIGURS1.  This is confusing.  I believe
> removing the words "Block SIGINT; " would clarify the example.
>
> Sorry for not sending a patch, the git repo seems to still be down.
> (from here: git://git.kernel.org/pub/scm/docs/man-pages/man-pages.git)
>
> Please CC on any replies, I am not on these mailing lists.
>
> -pat
>
> relevant bits:
>
>  /* Block SIGINT; other threads created by main() will inherit
>              a copy of the signal mask. */
>
>           sigemptyset(&set);
>           sigaddset(&set, SIGQUIT);
>           sigaddset(&set, SIGUSR1);
>           s = pthread_sigmask(SIG_BLOCK, &set, NULL);

Thanks for this report. For man-pages-3.36, I applied the patch below.

Cheers,

Michael

--- a/man3/pthread_sigmask.3
+++ b/man3/pthread_sigmask.3
@@ -110,8 +110,8 @@ main(int argc, char *argv[])
     sigset_t set;
     int s;

-    /* Block SIGINT; other threads created by main() will inherit
-       a copy of the signal mask. */
+    /* Block SIGQUIT and SIGUSR1; other threads created by main()
+       will inherit a copy of the signal mask. */

     sigemptyset(&set);
     sigaddset(&set, SIGQUIT);


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Author of "The Linux Programming Interface"; http://man7.org/tlpi/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html