Re: [PATCH 1/1] Changes for 68000 code integration.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Fri, Apr 27, 2012 at 08:43, Greg Ungerer <gerg@xxxxxxxxxxxx> wrote:
On 27/04/12 09:08, Luis Alves wrote:
This is the first of a pack of patches to support the original 68000 cpu.
This adds:
 -MC68000 cpu as a choice in the config menu.
 -Alcetronics M68K board (uses this cpu).

Nice!

But the actual arch/m68k/platform/68000/ part is missing?

 -Modified CONFIG_MCPU32 to select CONFIG_M68XXX.
 -Modified CONFIG_M68360 to select CONFIG_M68XXX (I think it was missing
some settings).
 -Modified some files to use CONFIG_M68XXX instead of
CONFIG_M68000/CONFIG_MCPU32

Although there was no true 68000 part supported before the intention
of the CONFIG_M68000 define was for that CPU - or any SoC type part that
contained a true 68000 CPU core. And it would be good to keep that

Indeed.

naming so it is consistent with the other 680x0 cores.

Indeed, ...

-#if defined(CONFIG_M68000) || defined(CONFIG_COLDFIRE)
+#if defined(CONFIG_M68XXX) || defined(CONFIG_COLDFIRE)

"CONFIG_M68XXX || CONFIG_COLDFIRE" makes me think "Isn't this always
true?"...

 /*
  * The simpler m68k and ColdFire processors do not have a 32*32->64
  * multiply instruction. So we need to handle them a little differently.
diff --git a/arch/m68k/lib/memcpy.c b/arch/m68k/lib/memcpy.c
index 10ca051..c0a1ae8 100644
--- a/arch/m68k/lib/memcpy.c
+++ b/arch/m68k/lib/memcpy.c
@@ -22,7 +22,7 @@ void *memcpy(void *to, const void *from, size_t n)
               from = cfrom;
               n--;
       }
-#if defined(CONFIG_M68000)
+#if defined(CONFIG_M68XXX)

... and CONFIG_M68XXX sounds like it's set for e.g. '020 too.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Video for Linux]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Video Projectors]     [Linux Kernel]     [Linux SCSI]     [XFree86]

Add to Google Powered by Linux