Re: [PATCH 00/22] m68knommu: simplify ColdFire GPIO init code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Wednesday 25 April 2012 5:25:40 pm gerg@xxxxxxxxxxxx wrote:
The GPIO init code for the ColdFire cores is a set of very large tables,
one for each ColdFire SoC type. Each SoC type has very different GPIO pin
arrangements, so one for each is unavoidable. But there is fundamentaly
two types of setup/access that we are trying to support.

With some pre-processor macro magic we can reduce the tables significantly,
making them easier to read, easier to get correct, and easier to maintain.

The following patches implement a set of simplifying changes. What do
others think?  Overall we remove close to 2000 lines of code, and the end
tables are much easier to read and get correct.

Hi Greg,

This looks fine to me.
You can add my Acked-by: Steven King <sfking@xxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

[Video for Linux]     [Photo]     [Yosemite News]    [Yosemite Photos]    [Video Projectors]     [Linux Kernel]     [Linux SCSI]     [XFree86]

Add to Google Powered by Linux